Skip to content

Remove unused global cmd_split variable. #9640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2017
Merged

Remove unused global cmd_split variable. #9640

merged 1 commit into from
Oct 31, 2017

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Oct 31, 2017

(very technically breaks backcompat, but it's not as if these were
likely to be used at all or as if there was a good way to emit a
warning.)

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Remove unused global cmd_split variable.
8cd97c1 
(*very* technically breaks backcompat, but it's not as if these were
likely to be used at all or as if there was a good way to emit a
warning.)
@tacaswell tacaswell added this to the v2.2 milestone Oct 31, 2017
dopplershift
dopplershift approved these changes Oct 31, 2017
View reviewed changes
Copy link
Contributor

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending CI.

@Kojoley Kojoley merged commit 6873a6e into matplotlib:master Oct 31, 2017
@anntzer anntzer deleted the remove-unused-globals branch October 31, 2017 21:01
@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@dopplershift dopplershift dopplershift approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@anntzer @tacaswell @dopplershift @QuLogic @Kojoley