Skip to content

Backport PR #9324 on branch v2.1.x #9644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 3, 2017
Merged

Conversation

lumberbot-app[bot]
Copy link

@lumberbot-app lumberbot-app bot commented Oct 31, 2017

Backport PR #9324: [MRG] Allow kwarg handles and labels figure.legend and make doc for kwargs the same

@lumberbot-app lumberbot-app bot added this to the v2.1.1 milestone Oct 31, 2017
@QuLogic QuLogic closed this Nov 2, 2017
@QuLogic
Copy link
Member

QuLogic commented Nov 2, 2017

Rebuild with old pandas, hopefully.

@QuLogic QuLogic reopened this Nov 2, 2017
@QuLogic
Copy link
Member

QuLogic commented Nov 3, 2017

@jklymak your legend docstring test does not seem to be passing.

@jklymak
Copy link
Member

jklymak commented Nov 3, 2017

Ummm, not sure how it passes on Master but not on the backport? No idea how I'm supposed to fix this. More than willing to help, however...

@jklymak
Copy link
Member

jklymak commented Nov 3, 2017

The problem is that somehow the _axes.legend didn't get changed to have the correct docstring. Not sure how that happened as its correct in master....

@jklymak
Copy link
Member

jklymak commented Nov 3, 2017

Can I simply work off this branch and push commits?

@QuLogic QuLogic merged commit 24ba7a8 into v2.1.x Nov 3, 2017
@QuLogic QuLogic deleted the auto-backport-of-pr-9324 branch November 3, 2017 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants