Skip to content

Convert dviread to use lru_cache. #9646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2017
Merged

Convert dviread to use lru_cache. #9646

merged 1 commit into from
Nov 1, 2017

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Oct 31, 2017

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

QuLogic
QuLogic approved these changes Nov 1, 2017
View reviewed changes
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The caching is slightly different, but I think this is better.

@tacaswell tacaswell added this to the v2.2 milestone Nov 1, 2017
@dopplershift dopplershift merged commit 2ed9013 into matplotlib:master Nov 1, 2017
@anntzer anntzer deleted the lru_cache branch November 1, 2017 17:14
@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @dopplershift @QuLogic @tacaswell