Correct https git URIs in documentation #9648
Conversation
Fix a few instances in the documentation where http(s):// git URIs contained a colon rather than a slash to separate the host from the path. Using a colon is malformed, and results in an error (at least on my git 2.13.3, perhaps other versions try harder to guess): ``` $ git clone https://github.com:matplotlib/matplotlib.git Cloning into 'matplotlib'... fatal: unable to access 'https://github.com:matplotlib/matplotlib.git/': Port number ended with 'm' ```
|
No, the form with a colon is correct, you should not specify https but (literally) Conversely the form with a slash needs explicitly https:// -- we just need to settle on one. However I would strongly suggest opening the issue at https://github.com/matthew-brett/gitwash instead, which is where these files get generated from. There is indeed a typo in gith hub that needs to be fixed. |
|
It's already written with However, I do agree that this should be sent to gitwash as well. |
|
oh is it just for me or does github render https://github.com/matplotlib/matplotlib/pull/9648/files stripping the 'https://'? (looking at https://github.com/matplotlib/matplotlib/commit/4bcf44940644979a06a2c8a220d95668590a1fd2.patch the patch is clearly correct indeed). |
Backport PR #9648 on branch v2.1.0-doc
Fix a few instances in the documentation where
http(s)://git URIs contained a:rather than a/to separate the host from the path.Using a colon is malformed, and results in an error (at least on my git 2.13.3, perhaps other versions try harder to guess):
PR Summary
PR Checklist