Skip to content

Change set_figwidth/height to be consistent w/ set_size_inches #9715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2017
Merged

Change set_figwidth/height to be consistent w/ set_size_inches #9715

merged 1 commit into from
Nov 11, 2017

Conversation

jklymak
Copy link
Member

@jklymak jklymak commented Nov 7, 2017 •
edited
Loading

PR Summary

Makes set_figwidth/height to be consistent w/ set_size_inches as per #9669. Not called elsewhere in our code base, but theoretically an API change...

See #6131 for cross-ref of the change w/ set_size_inches.

PR Checklist

  • Code is PEP 8 compliant
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@jklymak jklymak requested review from mdboom and tacaswell November 8, 2017 00:10
@Kojoley Kojoley added this to the v2.2 milestone Nov 11, 2017
@efiring efiring merged commit 49b236d into matplotlib:master Nov 11, 2017
@jklymak jklymak mentioned this pull request Nov 12, 2017
Closed
@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kojoley Kojoley Kojoley approved these changes

@mdboom mdboom Awaiting requested review from mdboom

@tacaswell tacaswell Awaiting requested review from tacaswell

Assignees
No one assigned
Labels
API: changes API: consistency API: default changes
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jklymak @Kojoley @efiring @QuLogic