Use command keys for window shortcuts in Qt on OSX #9750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c134aa6 to
344ec8d
Compare
|
Hmm, but I'm pretty sure Meta is Super on Linux. Is this properly portable off macOS? |
Only make change on darwin
344ec8d to
1f93445
Compare
|
Turns out only the macOS specific lines need changing to work. |
dopplershift
approved these changes
Dec 4, 2017
|
should this be backported to 2.1.x? |
|
I suppose it's a bug fix, so sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2140
Other backends use "cmd" instead of "super" to denote the command key - with this change all the standard close/open/save shortcuts work on Qt with the command key.