-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
DOC: for datetime64 support #9794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7b06009
to
589bf7a
Compare
|
||
Matplotlib has supported `datetime.datetime` dates for a long time. We | ||
now support `numpy.datetime64` dates as well. This should be | ||
transparent to the user, and anywhere that `dateime.datetime` could be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "this should be transparent to the user" falls into the "this is simple/obvious/easy" ableist type language that I think should be avoided when possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just meant they shouldn't have to do anything special to make it happen. i.e. there is no new API, they just use plot
or date2num
as they always have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might be clearer to say that? np.datetime is now a supported type, so np.datetime objects can now be used as data inputs to any plotting function that already supports dates.
and num2date | ||
|
||
All matplotlib date plotting is done by converting date instances into days | ||
since 0001-01-01 00:00:00 UTC plus one day (for historical reasons). The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What historical reasons? Is there a link to the discussion anywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. can you link to that discussion in this text to provide context.
a9e5209
to
3e3d984
Compare
d75440e
to
fefbd64
Compare
This is OK. Couldn't get inter sphinx |
Maybe try :numpy:class:`datetime64` ? |
That doesn't appear anywhere else in the codebase. Others have use EDIT: I'll try again w/ :class: |
fefbd64
to
59cd00d
Compare
That doesn't work either. Opened issue... #9802 |
PR Summary
Should have been in #9779. Sorry!
PR Checklist