dynamically finding the backend preferred format for button images #9811
Conversation
lib/matplotlib/backend_bases.py
Outdated
| """ | ||
| Get the preferred image extension | ||
|
|
||
| Return |
lib/matplotlib/backend_bases.py
Outdated
| if os.path.isfile(fname): | ||
| return fname | ||
|
|
||
| def btn_image_extension(self): |
There was a problem hiding this comment.
"preferred_image_extension"?
There was a problem hiding this comment.
It is not actually a preference, it is matter of "does it work?"
There was a problem hiding this comment.
supported_...
(it's not as if you have to repeat this name again and again many places through the codebase so you may as well avoid abbreviating it).
There was a problem hiding this comment.
could we get away with just having a class-level attribute of _icon_extension ?
There was a problem hiding this comment.
probably would work too...
There was a problem hiding this comment.
That was my first idea, but I didn't like creating a property with a raise AttributeError in the base class.
But i guess you're right, it is alot easier and cleaner for the final implementation of the backend
There was a problem hiding this comment.
Make it None on the base class which will make it raise a TypeError when fetching the attribute if not overridden?
|
FWIW recent tkinters should support png out of the box (https://stackoverflow.com/a/27601573/378080). |
|
@tacaswell I changed it to a class attribute as suggested, I think it is cleaner this way |
|
Repro'ing my comment that got folded when the code was patched away:
|
|
I think it is ok to leave it as |
|
Done!, added a default format |
|
I think this will need a manual rebase against current |
PR Summary
The Tools used by Toolmanager assumed every backend understood
.pngfiles for the button images.This is not the case, for example tk works with png in linux but not on mac
This pr fixes this by asking each backend for it's preferred image format
PR Checklist