Deprecate Artist.onRemove, Artist.hitlist. #9825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
requested changes
Nov 23, 2017
|
Pfff, you got away without one in #3988 :-) |
Artist.onRemove is unused and untested; it could (should?) have been deprecated at the same time as Artist.onHilite. Artist.hitlist is only used in one example which I rewrote in a more efficient manner (no need to test every artist for containment), and can be easily replaced by a list comprehension (except for the Exception-silencing part, which is probably misguided to start with...).
3cc889b to
a2caa86
Compare
jklymak
approved these changes
Dec 2, 2017
tacaswell
approved these changes
Dec 3, 2017
|
@anntzer We should always strive to do better |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Artist.onRemove is unused and untested; it could (should?) have been
deprecated at the same time as Artist.onHilite (#3988).
Artist.hitlist is only used in one example which I rewrote in a more
efficient manner (no need to test every artist for containment), and can
be easily replaced by a list comprehension (except for the
Exception-silencing part, which is probably misguided to start with...).
PR Summary
PR Checklist