Skip to content

Deprecate unused FigureManagerBase.show_popup. #9915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 3, 2017
Merged

Deprecate unused FigureManagerBase.show_popup. #9915

merged 2 commits into from
Dec 3, 2017

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Dec 2, 2017

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@jklymak
Copy link
Member

jklymak commented Dec 2, 2017

Do we actually need to deprecate something that doesn't do anything? Like I guess someone could have left this call in their code, been so sad that it didn't do anything that they forgot to remove it, but...

@anntzer
Copy link
Contributor Author

anntzer commented Dec 2, 2017

I would argue not, but I'm not the one who sets the policy.

jklymak
jklymak approved these changes Dec 2, 2017
View reviewed changes
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine unless somehow the tests break!

@tacaswell
Copy link
Member

This looks to be a 12 year-old bread crumb (e945059) that never got build out!

@tacaswell tacaswell added this to the v2.2 milestone Dec 3, 2017
@tacaswell
DOC: update deprecation note.
7c4cecd 
Add context to where this method came from.
@dstansby dstansby merged commit c1a22a1 into matplotlib:master Dec 3, 2017
@anntzer anntzer deleted the depr-show-popup branch December 3, 2017 18:08
@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@anntzer @jklymak @tacaswell @QuLogic @dstansby