Skip to content

Explicit tool registration. #9941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Explicit tool registration. #9941

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7ee87af
Explicit tool registration.
anntzer Dec 6, 2017
fc1e1a8
Remove Rubberband tool and data kwarg to trigger.
anntzer Dec 6, 2017
3a0ba93
Remove sender argument to trigger.
anntzer Dec 6, 2017
6e3122a
Fix example.
anntzer Dec 6, 2017
a1e88f4
Remove _get_cls_to_instantiate.
anntzer Dec 6, 2017
969f311
Dispatch tool on canvas class.
anntzer Dec 6, 2017
5eae7bf
Name as tool attribute.
anntzer Dec 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove _get_cls_to_instantiate.
  • Loading branch information
@anntzer
anntzer committed Jan 4, 2018
commit a1e88f4094403e4f08346e40e2b7161e5a8be00e
17 changes: 0 additions & 17 deletions lib/matplotlib/backend_managers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,23 +325,6 @@ def _handle_toggle(self, tool, canvasevent):
# Keep track of the toggled tool in the radio_group
self._toggled[radio_group] = toggled

def _get_cls_to_instantiate(self, callback_class):
# Find the class that corresponds to the tool
if isinstance(callback_class, six.string_types):
# FIXME: make more complete searching structure
if callback_class in globals():
callback_class = globals()[callback_class]
else:
mod = 'backend_tools'
current_module = __import__(mod,
globals(), locals(), [mod], 1)

callback_class = getattr(current_module, callback_class, False)
if callable(callback_class):
return callback_class
else:
return None

def trigger_tool(self, name, canvasevent=None):
"""
Trigger a tool and emit the tool_trigger_[name] event
Expand Down