-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Errorbars accept marker_options and follow prop_cycle #9952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This really needs a test... If you need help, let us know. http://matplotlib.org/devdocs/devel/testing.html |
... and probably an example, API change note... |
PEP8 D'oh! I'll fix that and add the example + changeling entry tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just needs the test image changing to the latest style, thanks a lot @as691454 for this!
lib/matplotlib/tests/test_axes.py
Outdated
@@ -2815,6 +2815,16 @@ def test_errobar_nonefmt(): | |||
assert np.all(errbar.get_color() == mcolors.to_rgba('C0')) | |||
|
|||
|
|||
@image_comparison(baseline_images=['errorbar_with_prop_cycle'], | |||
extensions=['png']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this get a style=mpl20
argument so it uses the new style?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. thanks for the nudge. i can't the docs to build properly on my machine at home so this has stalled out a bit.
…ies from axes.prop_cycle
Thanks all, it was a team effort but we got it done! (PS hope its OK that I merged - my commits only changed the style of the test to mpl20 and remove_text=True) |
#9920 #9922
Errorbars now
The first one is important for making black and white plots (clear and filled squares) - cheaper to publish than color graphs. Property cycle fix is nice for plotting several lines at once from pandas DataFrame, for instance.