Skip to content

BUG: clear events before destroying windows in tkagg #9956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2017
Merged

BUG: clear events before destroying windows in tkagg #9956

merged 1 commit into from
Dec 13, 2017

Conversation

mattip
Copy link
Contributor

@mattip mattip commented Dec 8, 2017

Fixes issue #9856 by clearing events while destroying.

Alternative implementation: call flush_events() in close_events() in FigureCanvasAgg, which might help other backends?

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@mattip
Copy link
Contributor Author

mattip commented Dec 8, 2017

There seem to be a number of issues related to TkAgg and the message loop: #9856, #8129, #9077, #8845.
Since AFAICT pull requests #9275, #9356 seem to be approved, could they be merged to master? It would make determining how this pull request affects the other issues easier.

@mattip mattip mentioned this pull request Dec 8, 2017
Closed
@jklymak
Copy link
Member

jklymak commented Dec 8, 2017

This works fine for me on OS X, with no unsightly messages.

@tacaswell tacaswell added this to the v2.2 milestone Dec 8, 2017
@anntzer
Copy link
Contributor

anntzer commented Dec 9, 2017 •
edited
Loading

This is not fixed by #9275 (dunno, just asking)?

@jklymak
Copy link
Member

jklymak commented Dec 9, 2017

No. I was testing off master and got those errors

@duynguyenhoang
Copy link

Fixed #9856 for me
get_backend() == TkAgg
MacOS 10.12.6
Python 3.6.2

@anntzer anntzer mentioned this pull request Dec 11, 2017
Merged
6 tasks
@tacaswell tacaswell merged commit 2132073 into matplotlib:master Dec 13, 2017
@tacaswell
Copy link
Member

May not be the perfect solution, but is an improvement over status-quo.

@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
@mattip mattip deleted the tkagg-issue9856 branch February 15, 2018 23:07
@mattip mattip mentioned this pull request Oct 29, 2018
Closed
@richardsheridan richardsheridan mentioned this pull request Jun 29, 2020
Merged
6 tasks
@richardsheridan richardsheridan mentioned this pull request Sep 27, 2020
Merged
7 tasks
@richardsheridan richardsheridan mentioned this pull request Jun 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
GUI: tk
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.
7 participants
@mattip @jklymak @anntzer @duynguyenhoang @tacaswell @QuLogic @dstansby