Add a ping endpoint to webhook service #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As noted in matplotlib#25, the webhook was down for some period. The ping endpoint allows some external check to verify that it is running. If Caddy cannot connect to the webhook, it will return 502 instead of 200.
tacaswell
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #25, the webhook was down for some period.
Previously, our health check was hitting
/ghand looking for a 404. However, the Caddy config only passes/gh/*to the webhook, with a 404 for any other path. This meant that the checked path was always hitting Caddy's fall back and never actually checking that the webhook service was up. With a/pingendpoint, we have a dedicated URL to check and it can return a normal 200. If Caddy cannot connect to the webhook, it will return 502 instead of 200.