Skip to content

Add a ping endpoint to webhook service #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Aug 18, 2022

As noted in #25, the webhook was down for some period.

Previously, our health check was hitting /gh and looking for a 404. However, the Caddy config only passes /gh/* to the webhook, with a 404 for any other path. This meant that the checked path was always hitting Caddy's fall back and never actually checking that the webhook service was up. With a /ping endpoint, we have a dedicated URL to check and it can return a normal 200. If Caddy cannot connect to the webhook, it will return 502 instead of 200.

As noted in matplotlib#25, the webhook was down for some period. The ping endpoint
allows some external check to verify that it is running. If Caddy cannot
connect to the webhook, it will return 502 instead of 200.
@QuLogic QuLogic added the bug Something isn't working label Aug 18, 2022
@tacaswell tacaswell merged commit 6c83f7c into matplotlib:main Aug 26, 2022
@QuLogic QuLogic deleted the webhook-health branch August 26, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants