Skip to content

Use magicgui to generate GUI in SliceWidget #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dstansby opened this issue May 10, 2022 · 1 comment
Closed

Use magicgui to generate GUI in SliceWidget #48

dstansby opened this issue May 10, 2022 · 1 comment
Labels
good first issue Good for newcomers

Comments

@dstansby
Copy link
Member

When I implemented SliceWidget, I manually built the GUI and widgets using qtpy. It would make much nicer code if this was done with magicgui however. For an existing example of how to do this see:

napari-matplotlib/src/napari_matplotlib/scatter.py

Lines 130 to 136 in 081d4b6

self._key_selection_widget = magicgui(
self._set_axis_keys,
x_axis_key={"choices": self._get_valid_axis_keys},
y_axis_key={"choices": self._get_valid_axis_keys},
call_button="plot",
)
self.layout().addWidget(self._key_selection_widget.native)

@dstansby dstansby added the good first issue Good for newcomers label May 10, 2022
@dstansby dstansby mentioned this issue May 10, 2022
Closed
@dstansby
Copy link
Member Author

Given the leaks I've fixed in #108 were caused by using magicgui, I'm going to close this as something that shouldn't be done.

@dstansby dstansby closed this as not planned Won't fix, can't repro, duplicate, stale May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use magicgui for slice widget matplotlib/napari-matplotlib
1 participant
@dstansby