Skip to content

Add test_scatter.png so tox passes in other branch #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add test_scatter.png so tox passes in other branch #123

wants to merge 1 commit into from

Conversation

ruaridhg
Copy link
Collaborator

@ruaridhg ruaridhg commented May 18, 2023 •
edited
Loading

Refers to #122
Want to merge this branch to add test_scatter.png so I can run tox for the scatter_test.py in another branch

@ruaridhg ruaridhg requested a review from dstansby May 18, 2023 14:26
@dstansby
Copy link
Member

I'm confused by this PR - why is there a test image without a corresponding figure test?

@ruaridhg
Copy link
Collaborator Author

I'm confused by this PR - why is there a test image without a corresponding figure test?

I've tested locally and it produced this test image. When tox runs on the test_scatter on the other PR #121 it copies the baseline folder which doesn't contain this image so tox fails. This was me trying to find a workaround to upload the test image prior to test on the other branch/PR, but if it's too hacky I can try to figure out another way for it to work. It may be running pytest-mpl twice in the tox file

@dstansby dstansby removed their request for review May 30, 2023 12:36
dstansby
dstansby requested changes May 31, 2023
View reviewed changes
Copy link
Member

@dstansby dstansby left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding new test image files should come along with a test that uses the file, so I'm still confused by this PR.

@ruaridhg ruaridhg closed this May 31, 2023
@ruaridhg ruaridhg reopened this May 31, 2023
@ruaridhg
Copy link
Collaborator Author

Adding new test image files should come along with a test that uses the file, so I'm still confused by this PR.

I think that this can be closed for now as it can be dealt with in another branch once the scatter test is working

@ruaridhg ruaridhg closed this May 31, 2023
@dstansby dstansby mentioned this pull request Jun 1, 2023
Closed
@dstansby dstansby added the Tests label Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstansby dstansby dstansby requested changes

Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruaridhg @dstansby