Skip to content

Put scatter and features scatter tests in different files #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2023
Merged

Put scatter and features scatter tests in different files #150

merged 1 commit into from
Jun 2, 2023

Conversation

dstansby
Copy link
Member

@dstansby dstansby commented Jun 2, 2023

This makes it easier to quickly see what tests are defined for the two different widgets. Tested locally to make sure that the tests still run after being moved.

@dstansby dstansby marked this pull request as ready for review June 2, 2023 09:41
@dstansby dstansby requested review from samcunliffe and ruaridhg June 2, 2023 09:41
ruaridhg
ruaridhg approved these changes Jun 2, 2023
View reviewed changes
Copy link
Collaborator

@ruaridhg ruaridhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me locally

@ruaridhg ruaridhg added this pull request to the merge queue Jun 2, 2023
Merged via the queue into matplotlib:main with commit e481734 Jun 2, 2023
@dstansby dstansby added the Tests Adding to or fixing the tests label Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruaridhg ruaridhg ruaridhg approved these changes

@samcunliffe samcunliffe Awaiting requested review from samcunliffe

Assignees
No one assigned
Labels
Tests Adding to or fixing the tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dstansby @ruaridhg