Skip to content

Don't duplicate CI on merge to main #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Don't duplicate CI on merge to main #161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/test_and_deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ name: tests

on:
push:
branches:
- main
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I claim this will make it even harder to solve #155 because then there'll be no builds reporting the coverage from main. It's good from a 🌱 perspective though. No need to duplicate server work.

Happy to approve as an experiment, but I'm still betting on my if: ${{ !contains(github.ref, 'gh-readonly-queue/') }} as more likely to solve. (Unfortunately, any play tests have to go onto main, by construction.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that's a good point. Lets hold off on merging this, and I'll dive into the codecov docs to see what they recommend re. merge queues?

tags:
- "v*" # Push events to matching v*, i.e. v1.0, v20.15.10
pull_request:
Expand Down