Add doc deployment job #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samcunliffe
commented
Jun 15, 2023
.github/workflows/docs.yml
Outdated
| name: docs | ||
|
|
||
| - name: Push to GitHub pages | ||
| uses: peaceiris/actions-gh-pages@v3 |
There was a problem hiding this comment.
Probs only want to publish the docs for commits to main.
Suggested change
| uses: peaceiris/actions-gh-pages@v3 | |
| uses: peaceiris/actions-gh-pages@v3 | |
| if: github.event_name == 'push' && github.ref_name == 'main' |
And we could switch to JamesIves' action.
dstansby
requested changes
Jun 15, 2023
Closed
dstansby
reviewed
Jun 15, 2023
dstansby
reviewed
Jun 15, 2023
|
Upload is now working. The settings page says the site should be at https://matplotlib.org/napari-matplotlib/, but it is not. I suggest we 🚢 this, and I'll chat to the Matplotlib org admins about how to sort out the domain stuff.
|
dstansby
approved these changes
Jun 15, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of the first commit from #166 but where the branch is not from a fork, but from @matplotlib's repo directly.
Probably you need to set up the pages from the
gh-pagesbranch in the repo settings? Because there's nothing at https://matplotlib.github.io/napari-matplotlib