Skip to content

Ensure HistogramWidget always uses 100 bins by default #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 23, 2024
Merged

Ensure HistogramWidget always uses 100 bins by default #250

merged 2 commits into from
Jan 23, 2024

Conversation

p-j-smith
Copy link
Contributor

Fixes #249

  • create 100 bins (101 bins edges) for binning float data rather than 99 bins (100 bin edges)
  • this is to make it possible to use the same number of bins for integer and float data that have the same values
  • update baseline images to reflect change in number of bins (99 -> 100)

@dstansby dstansby added the Changelog needed A user-facing change which requires a note in the changelog. label Jan 23, 2024
@dstansby dstansby merged commit 559e1c1 into matplotlib:main Jan 23, 2024
@dstansby dstansby added this to the 2.0.1 milestone Jan 23, 2024
@dstansby dstansby added Bug Something isn't working and removed Changelog needed A user-facing change which requires a note in the changelog. labels Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
2.0.1
Development

Successfully merging this pull request may close these issues.

napari_matplotlib.histogram._get_bins returns different bins depending on type of data passed to it
2 participants
@p-j-smith @dstansby