-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
WIP: Configure mailer messenger #11180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a8280dc
to
57cb36a
Compare
dff5f58
to
973e9ca
Compare
7c59457
to
e4dd656
Compare
@escopecz I would appreciate your support in fixing the failing tests, the failing tests are failing only on GitHub but on my local machine they work. is there something I am missing? For Rector, It changes core files with doctrine which makes Mautic fail. As for stan, it is showing errors for files that I did not change And CSfixer is trying to fix files I deleted, maybe there is PR on 4.x that would fix this issue. |
Try to run the whole phpunit test suite. It looks like the hard-coded IDs in some tests do not match anymore. Maybe you added a new test before these that is messing with the hard-coded IDs that it expects. There are 2 ways to fix it:
PHPSTAN is checking the whole project. If you change one file it can affect others. That's normal and must be fixed. I'm not sure what Rector is doing. 4.3 is coming with new versions of PHPSTAN and Rector so we can see what will happen after we merge that into this PR. |
I am waiting on this symfony/symfony#33394 to be merged so we can save the messages as JSON instead of serilazed PHP object |
80b0efb
to
22d4940
Compare
22d4940
to
0e641d0
Compare
Symfony/Messenger
andSymfony/Mailer
insteadDescription:
Messenger Bundle
This PR introduce a new bundle called
MessengerBundle
which integratesSymfony/Messenger
which acts as the main bus and queue engine for Mautic.How this bundle works?
doctrine
(database) as the default queue where it store messages before sending.local.php
in format of DNS, this DNS is composed in each plugin that inject itself as a messenger pluginenv var
that we use to define the consumer name.MAUTIC_MESSENGER_CONSUMER_NAME
this will change the name of consumer that will listen to the queue and dispatch the messages.mautic:email:send
has been deleted because of this bundle, and thespool
functionality as well.php bin/console messenger:consume
What is missing for this bundle
Email Bundle
In the email bundle we rely on
[Symfony/Mailer](https://symfony.com/doc/current/mailer.html)
and removed all the references to swiftmailerWhat has changed ?
amazon_api
has been changed toses+api
.ses+api:username:password@default?region=us-east-1
What is missing for this bundle
This PR introduce the following improvements:
Steps to test this PR: