[feature] add probablistic data structure bloomfilter #151

DengYiping · 2019-03-09T07:29:19Z

Changes:

add helper data structure bitmap implementation
implement the bloomfilter using the bitmap.
necessary unit test for the bloomfilter
Note:
Bloom filter is completely probabilistic. There is a chance that the test case will fail, but it not likely to happen since the threshold I set in the test case is quite high

src/data-structures/bloomfilter.js

mgechev

Great job! The implementation looks technically correct to me, and I love how you've cited the original source of the hash function.

Few general comments about the style of the comments (mostly personal preference based on the projects I've worked on):

Start with a capital letter
After // add a space
Move the single-line comments above the lines they address

DengYiping · 2019-03-10T17:41:55Z

@mgechev Thanks for the feedback. I will fix the implementation accordingly.

add probablistic data structure bloomfilter

a5e865e

DengYiping changed the title ~~[feature] Add probablistic data structure bloomfilter~~ [feature] add probablistic data structure bloomfilter Mar 9, 2019