Improved prime check and Fisher Yates #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Looks great! Travis CI build has failed, would you take a look at the error here and fix it? As far as I saw, the code doesn't pass the jscs rules. |
|
Sorry, fixed indents! |
|
Looks good to me. Merging. |
JakeHP
added a commit
that referenced
this pull request
Aug 15, 2015
Improved prime check and Fisher Yates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I just improved the prime check and the Fisher Yates shuffle algorithm. Sorry for pulling both in one request. If you want to accept just one, I can split them up.
The implementation of the Richard Durstenfeld algo is also not correct, but maybe you can drop it, as it is just a modified Fisher Yates.
Robert