-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
tests/extmod/ussl_basic.py fails for modussl_mbedtls #4364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hmm.. They really expect an inherently different behavior. What should we do in such case? Is there any option to run tests based on external reading of Btw, this partly stems the same problem as I've described in #4475. |
That test is just a hack.
Adding more bytes is not allowed ;-). (Well, in coverage build, everything is allowed). |
In the CI, |
Well, as I told, that test is hack. Patching it with even more hacks unlikely seems like a good investment of effort. Instead imagine how a real test would be written: allow to override time and random sources for the underlying TLS lib, then feed predefined/read expected TLS records. Well, could also implement real TLS handling on the tester side ;-). If it doesn't do that, it's a hack. And if some lines of a hack doesn't work with different TLS implementations, those lines are very bad hack. Their removal is obvious solution. Well, could also keep them in a dirty attempt to keep coverage, just test for variants of expected behavior explicitly (not by printing stuff). |
Note that #4481 was posted also as an example that adding any adhoc, mis-leveled tests (which test not TLS, but low-levelish, corner behavior of current implementations) would only complicate matters. |
Fixes issue micropython#4364. Signed-off-by: Damien George <damien@micropython.org>
Fixes issue micropython#4364. Signed-off-by: Damien George <damien@micropython.org>
Fixes issue micropython#4364. Signed-off-by: Damien George <damien@micropython.org>
Fixed by 18ecc29 |
Fixes issue micropython#4364. Signed-off-by: Damien George <damien@micropython.org>
Fixes issue micropython#4364. Signed-off-by: Damien George <damien@micropython.org>
Well, subj. ussl_basic.py is coded too much relying on modussl_axtls behavior.
The text was updated successfully, but these errors were encountered: