Skip to content

unknown warning option '-Wimplicit-fallthrough=0' #7546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
oclyke opened this issue Jul 17, 2021 · 3 comments
Closed

unknown warning option '-Wimplicit-fallthrough=0' #7546

oclyke opened this issue Jul 17, 2021 · 3 comments
Labels
port-unix

Comments

@oclyke
Copy link
Contributor

oclyke commented Jul 17, 2021

Just went to build the dev variant of the unix port and got this error:

CC ../../lib/btstack/src/ad_parser.c
error: unknown warning option '-Wimplicit-fallthrough=0'; did you mean '-Wimplicit-fallthrough'? [-Werror,-Wunknown-warning-option]
make: *** [build-incident/lib/btstack/src/ad_parser.o] Error 1

Building on: macOS 10.15.7 (19H1217)
From commit: 8be29b9

I modified the file extmod/btstack/btstack.mk to omit the offending option entirely and was able to proceed through a successful build. No warnings were generated.

I understand this flag was added recently (#6578). Could this be a linux vs. osx issue?
@dpgeorge
Copy link
Member

This looks like a difference between gcc and clang. Probably that warning can be omitted when building with clang (eg put in the ifneq ($(CC),clang) part of the Makefile).

Might be a good idea to build micropython-dev on the mac CI.

@dpgeorge dpgeorge mentioned this issue Jul 17, 2021
Merged
dpgeorge added a commit to dpgeorge/micropython that referenced this issue Jul 17, 2021
@dpgeorge
extmod/btstack/btstack.mk: Use -Wno-implicit-fallthrough, not =0.
3b89c5b 
In 2ae3c89, -Wimplicit-fallthrough=0 was
added to get the build to pass.  This option is equivalent to
-Wno-implicit-fallthrough, and the latter is compatible with clang (while
the former is not).

Fixes issue micropython#7546.

Signed-off-by: Damien George <damien@micropython.org>
@dpgeorge
Copy link
Member

See #7547 for a fix, and also enabling of micropython-dev build on macOS CI.

dpgeorge added a commit to dpgeorge/micropython that referenced this issue Jul 17, 2021
@dpgeorge
extmod/btstack/btstack.mk: Use -Wno-implicit-fallthrough, not =0.
74db526 
In 2ae3c89, -Wimplicit-fallthrough=0 was
added to get the build to pass.  This option is equivalent to
-Wno-implicit-fallthrough, and the latter is compatible with clang (while
the former is not).

Fixes issue micropython#7546.

Signed-off-by: Damien George <damien@micropython.org>
@dpgeorge
Copy link
Member

Should be fixed by 74db526

RetiredWizard pushed a commit to RetiredWizard/micropython that referenced this issue Feb 9, 2023
@gamblor21
Merge pull request micropython#7546 from FoamyGuy/is31fl3741_fix
5f43a63 
fix for native is31fl3741
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
port-unix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dpgeorge @oclyke