tools/pyboard.py : Set DTR on Windows to avoid ESPxx hard reset. #10347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code size report: |
909e595 to
c6d82e4
Compare
Fixes issue micropython#9659. Signed-off-by: Jos Verlinde <Jos.Verlinde@Microsoft.com>
c6d82e4 to
d263438
Compare
|
Thanks for this, it's a decent solution to the problem (even if it is only specific to ESP devices). Regarding tests: it would be good to add tests for mpremote, and run them as part of CI. Probably the best way to do that would be to get mpremote working with the unix port (where the unix port acts in a special way like a bare-metal board and supports soft reset). But even if that existed it wouldn't help with the issue here, which is specific to Windows and serial ports. So I'm not really sure how to integrate such hardware-specific tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9659
Based on @mgsb's proposal in #9659 (comment) with added logic to only apply the fix to Windows hosts
Tests
Tested on :
As there are currently no tests for mpremote in the repo I have created a stand alone test for this using pytest :
https://gist.github.com/Josverl/57159ee096dc941f294c745056fe341c
Happy to add test, but currently the build / test process for mpremote is not clear to me