windows/msvc: Remove variant suffix from executable filename. #10556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in line with the change made for other ports in d53c3b6: since the default output directory already includes the variant name in it there's no need to add it to the executable as well.
|
Thanks, this looks fine. Good to keep it consistent with the unix port et al. |
|
I'm looking into frozen modules with msvc so am going to to close this in favor of another PR which has other fixes to the same file, it's nicer if all those commits are going to be consecutive in the history. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in line with the change made for other ports in d53c3b6: since the default output directory already includes the variant name in it there's no need to add it to the executable as well.
Sorry I completely looked over this both for #7780 and #10133. Or perhaps thought there was a good reason to not change it, but currently I don't see any :)