This is an automated heads-up that we've just merged a Pull Request
that removes the STATIC macro from MicroPython's C API.

See #13763

A search suggests this PR might apply the STATIC macro to some C code. If it
does, then next time you rebase the PR (or merge from master) then you should
please replace all the STATIC keywords with static.

Although this is an automated message, feel free to @-reply to me directly if
you have any questions about this.

@robert-hh thanks for working on this, sorry I didn't take proper notice of it until now.

I think we should merge this. It fixes obvious inconsistencies and makes the docs match the code behaviour.

Eventually we would bring all ports up to the same level of functionality (eg stm32) but for now this PR fixes things in a good way.

My only comment/question is: does it make sense to remove the init() method from the samd port? Why not fix it like it's done here for the other ports?

Thanks for looking into this. I was patient since you told to defer that until v2.
About SAMD: It's hard to remember my initial thoughts. The way it was, rtc.init() was identical to setting the date&time with rtc.datetime(). The difference for other ports is the position of the hour value. I can make it like that for SAMD as well.

Looking into the documentation for RTC.init(), it allows for a tuple between 3 and 8 items. The code for ESP32, MIMXRT and then SAMD requires ATM 8 items. Should I change the code or the documentation?

Edit: rtc,.init() is missing as well at the ESP8266 port. Could be added there.

The difference for other ports is the position of the hour value. I can make it like that for SAMD as well.

If it's not much work, would be good to make samd work this way.

Looking into the documentation for RTC.init(), it allows for a tuple between 3 and 8 items. The code for ESP32, MIMXRT and then SAMD requires ATM 8 items. Should I change the code or the documentation?

Supporting a variable number of arguments won't be easy, because the ports need to set all values at once. So I suggest to change the documentation, to make 8 arguments required. A variable number of arguments never worked anyway, so this doesn't break existing code.

Updated. I noticed that ESP8266 does not have the rtc.init() method. I could add it, if it's worth the code size increase.

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +0 +0.000% PYBV10
     mimxrt:  -128 -0.035% TEENSY40
        rp2:    +0 +0.000% RPI_PICO_W
       samd:   +20 +0.007% ADAFRUIT_ITSYBITSY_M4_EXPRESS
  qemu rv32:    +0 +0.000% VIRT_RV32

I noticed that ESP8266 does not have the rtc.init() method. I could add it, if it's worth the code size increase.

I don't think it's worth it, so let's leave that out.

Thanks for updating, now merged.

Thank you.