-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
extmod/modussl_mbedtls: Add closenotify() method #10783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3c91cee
to
eaaa21f
Compare
Signed-off-by: Dima Krasner <dima@dimakrasner.com>
eaaa21f
to
6c7c0a1
Compare
Code size report:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10783 +/- ##
==========================================
- Coverage 98.50% 98.48% -0.02%
==========================================
Files 155 155
Lines 20540 20544 +4
==========================================
Hits 20232 20232
- Misses 308 312 +4 ☔ View full report in Codecov by Sentry. |
Thanks for the contribution. This is not compatible with CPython, which doesn't have this If you were implementing a Gemini server to run under CPython, how would it work? |
I can move this to close(), requiring a CLOSING state before CLOSED. That would make close() a potentially blocking call. EDIT: looked at cpython, close_notify belongs in shutdown(). |
This is an automated heads-up that we've just merged a Pull Request See #13763 A search suggests this PR might apply the STATIC macro to some C code. If it Although this is an automated message, feel free to @-reply to me directly if |
Closing due to inactivity. If this is still of interest feel free to reopen with some more detailed discussion about how CPython handles this case. (Also note that MicroPython now has a |
Sending a FIN without a close_notify alert breaks some protocols: in my case, Gemini. (I'm running a Gemini server on a Pico W.)
This can block or slow down existing code that expects .close() not to do this, so it's a separate method.