-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
github/workflows: Add spell checking via codespell. #10911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Code size report:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #10911 +/- ##
=======================================
Coverage 98.49% 98.49%
=======================================
Files 155 155
Lines 20583 20583
=======================================
Hits 20273 20273
Misses 310 310
|
Unless there's an easy way to make it ignore those (something like a rule making it discard all uppercase things, plus lists of things to ignore like 'ure') it seems more like an annoyance. |
Yes there are lots of options. Like |
458c98a
to
6339b7e
Compare
OK, with some simple exclusions I've reduced the number of reported spelling mistakes down from 850 to 380. And most of these are spelling mistakes that should be corrected. |
Yeah that looks good. Well, apart from the spelling errors themselves :) |
I think it would help if contributors run a check with the same rules before committing.
One feature that I miss in codespell is to allow an override / ignore in code one example is that is just a comment, and can easily be rewritten. As a last comment, as a non-native-speaker: |
6339b7e
to
593abe7
Compare
Thanks for the feedback. I've now make a config file I've also only included certain directories at the moment in the spell check, to make it easier to pass CI. I excluded the I also fixed about 64 spelling mistakes in those directories that are included in the code spell CI.
In AU we usually use UK spelling 😄 I think |
This probably won't help IDE auto-detection of the config, which would expect to find .codespellrc (hopefully this would be configurable but it would be good to make it work out-of-the-box which is I think what @Josverl was suggesting). |
That should work. I can test tomorrow. Need to find a decent add= with proper support for the tool ide platform combo |
593abe7
to
ae75501
Compare
I've moved the config to |
6661815
to
60c8da5
Compare
The config in
|
Great, thanks for confirming |
60c8da5
to
65d1653
Compare
Signed-off-by: Damien George <damien@micropython.org> tools/ci.sh: Explicitly specify pyproject.toml. Signed-off-by: Damien George <damien@micropython.org> tools/ci.sh: Import tomli. Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
So that this file doesn't need to be excluded from codespell. Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
For convenience, eg for IDEs. Signed-off-by: Damien George <damien@micropython.org>
65d1653
to
867e4dd
Compare
Running
codespell
on this repo picks up quite a few spelling mistakes that would be good to fix.It also has lots of false positives...
Is this worth including in the CI?
Does it belong in the
code_formatting.yml
workflow, or in its own workflow?