Skip to content

tools: Remove unused import of serial #10992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2023
Merged

tools: Remove unused import of serial #10992

merged 1 commit into from
May 2, 2023

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Mar 10, 2023

This instance is a combination of an unused import and then a function parameter on line 576 with the same name.

tools/mpremote/mpremote/pyboardextended.py:1:20: F401 [*] `serial` imported but unused
tools/mpremote/mpremote/pyboardextended.py:576:24: F811 Redefinition of unused `serial` from line 1

@github-actions
Copy link

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +0 +0.000% PYBV10
        rp2:    +0 +0.000% PICO

@codecov-commenter
Copy link

Codecov Report

Merging #10992 (6d4616c) into master (4376c96) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master   #10992   +/-   ##
=======================================
  Coverage   98.50%   98.50%           
=======================================
  Files         155      155           
  Lines       20549    20549           
=======================================
  Hits        20241    20241           
  Misses        308      308

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cclauss cclauss mentioned this pull request Mar 10, 2023
Merged
@cclauss cclauss force-pushed the remove-unused-import-of-serial branch from 6d4616c to d2fea48 Compare March 10, 2023 09:26
@cclauss cclauss changed the title Remove unused import of serial tools: Remove unused import of serial Mar 10, 2023
@cclauss cclauss force-pushed the remove-unused-import-of-serial branch from d2fea48 to d55c87d Compare March 10, 2023 09:27
@dpgeorge dpgeorge added the tools Relates to tools/ directory in source, or other tooling label Apr 11, 2023
@dpgeorge dpgeorge force-pushed the remove-unused-import-of-serial branch from d55c87d to cda2929 Compare May 2, 2023 01:24
@dpgeorge dpgeorge merged commit cda2929 into micropython:master May 2, 2023
@dpgeorge
Copy link
Member

dpgeorge commented May 2, 2023

Thanks for the fix!

@cclauss cclauss deleted the remove-unused-import-of-serial branch May 2, 2023 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tools Relates to tools/ directory in source, or other tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cclauss @codecov-commenter @dpgeorge