drivers/ninaw10: Make GPIO0 pin optional. #11216
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This patch allows any board to use the driver without necessarily defining GPIO0 pin, which is only used by the Nina firmware as an IRQ signal and not really needed for the initialization sequence. * If GPIO0 is still defined it will be configured as input which can be read with `nina_bsp_read_irq()`.
|
Is this enough to fix the problem @robert-hh ? |
|
Hey! I just made exactly this change in the file set for a |
|
Yeah I tested WiFi and BT too, seems good. Ah I see this change is already included in your PR, so will close this down. |
|
If that ever get's merged. Looking at the GPIO0 pin with a logic analyzer, there is not a lot of activity there. Just two short low (!) pulses when connecting to an AP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nina_bsp_read_irq().