samd: Add the boards files for Adafruit Metro M4 Express Airlift. #11220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this blocked on #11219, or can it be merged without that? |
dpgeorge
reviewed
Apr 11, 2023
drivers/ninaw10/nina_wifi_bsp.c
Outdated
| mp_hal_pin_output(MICROPY_HW_NINA_GPIO0); | ||
| #ifdef MICROPY_HW_NINA_GPIO0 | ||
| mp_hal_pin_input(MICROPY_HW_NINA_GPIO0); | ||
| #endif |
There was a problem hiding this comment.
Please split these changes into a separate commit (so there's one commit for the ninaw10 changes, and one commit to add the new board).
There was a problem hiding this comment.
I'll remove this file from the PR.
f49d09a to
6128ef1
Compare
|
Updated. |
155a8a9 to
c97e277
Compare
The board files can be used for both Adafruit Metro M4 variants. The Wifi support is in progress.
|
Now merged. WiFi support can be enabled later, once #11219 is done. |
|
Thanks. I just added the definitions for the WiFi pins. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Wifi support by MicroPython is in PR #11219. The board files can be used for both Adafruit Metro M4 variants.