Skip to content

ports/esp32/ulp: Enable ULP (FSM) for S2 + S3. #11521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2023
Merged

ports/esp32/ulp: Enable ULP (FSM) for S2 + S3. #11521

merged 1 commit into from
May 19, 2023

Conversation

ThinkTransit
Copy link
Contributor

This pr enables the ULP for the S2 and S3 chips.

Note this is the FSM (Finite State Machine) ULP, not the RISCV ULP.

@ThinkTransit ThinkTransit changed the title ports/esp32/ulp: Enable ULP (FSM) for S2 + S3 ports/esp32/ulp: Enable ULP (FSM) for S2 + S3. May 16, 2023
@ThinkTransit ThinkTransit marked this pull request as ready for review May 16, 2023 15:11
@mattytrentini
Copy link
Contributor

Nice addition!

Perhaps we should update the ULP docs as well? Specifically to a) specify that it's the ULP FSM and b) that it's supported on ESP32/S2/S3.

@ThinkTransit
Copy link
Contributor Author

Nice addition!

Perhaps we should update the ULP docs as well? Specifically to a) specify that it's the ULP FSM and b) that it's supported on ESP32/S2/S3.

Good idea will do.

@ThinkTransit ThinkTransit marked this pull request as draft May 17, 2023 01:26
@ThinkTransit
Copy link
Contributor Author

Docs updated.

@ThinkTransit ThinkTransit marked this pull request as ready for review May 17, 2023 04:20
@stephanelsmith
Copy link
Contributor

Are there any updated examples on getting started with ULP on latest firmware?

Quick look found this:
https://github.com/micropython/micropython-esp32-ulp

Right direction?

@ThinkTransit @dpgeorge
esp32/esp32_ulp: Enable FSM ULP for S2 and S3 chips.
05e143d 
This commit enables the ULP for the S2 and S3 chips.

Note this is the FSM (Finite State Machine) ULP.

Signed-off-by: Patrick Joy <patrick@joytech.com.au>
@dpgeorge dpgeorge merged commit 05e143d into micropython:master May 19, 2023
@dpgeorge
Copy link
Member

Thank you!

@wnienhaus
Copy link
Contributor

Are there any updated examples on getting started with ULP on latest firmware?

Quick look found this: https://github.com/micropython/micropython-esp32-ulp

Right direction?

Yip, right direction, however at present micropython-esp32-ulp does not support the S2 and S3, because their ULP FSM is not binary compatible with that of the original ESP32. I'm currently busy adding support (see micropython/micropython-esp32-ulp#85 for status), so hopefully in a week or two there will be a testable version - would be happy to get feedback then.

@wnienhaus wnienhaus mentioned this pull request Jun 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
port-esp32
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ThinkTransit @mattytrentini @stephanelsmith @dpgeorge @wnienhaus