ports: Various additions and fixes. #11624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
robert-hh
commented
May 25, 2023
•
- Fix a regression for MIMXRT PWM, which caused setting duty_u16() behave like duty_ns() when the frequency was changed: the positive pulse duration did not change. That came up during testing for PR ports: mimxrt: Switch to official GitHub SDK (WIP) #11516. Fix an inconsistency when displaying a PWM pin's properties and improve the check for a pin to support PWM.
- Add the pinout information for the Adafruit Metro M7 board.
- Add the pinout information for the Adafruit Metro M4 board.
c5e18e7 to
9ad6d2e
Compare
Three bugs have been fixed in this commit: 1. When the duty was set with duty_u16(), changing the freq with pwm.freq() would not keep relative duty rate, but the absolute pulse duration. 2. Fix another inconsistency when displaying the PWM pin's properties of a QTMR channel. 3. Improve the error checks for the second channel being a PWM pin and pin pairs to be a FLEXPWM A/B pair. Signed-off-by: robert-hh <robert@hammelrath.com>
This one sets the flash image length properly for the teensy loader, such that the file system is not erased. It was already set in commit 8e54225 but got lost when the MIMXRT1176 board was added. Signed-off-by: robert-hh <robert@hammelrath.com>
Signed-off-by: robert-hh <robert@hammelrath.com>
Signed-off-by: robert-hh <robert@hammelrath.com>
|
Thank you. During merge I tweaked the PWM error messages to use "second" instead of "2nd", and "doesn't" instead of "does not" (for consistency with other messages). |
|
Thank you. May I ask for the state of PR #10233. The changes which you suggested are made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.