Skip to content

mpremote: Copy empty sub-dirs with "mpremote fs cp -r dir :". #11685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

mpremote: Copy empty sub-dirs with "mpremote fs cp -r dir :". #11685

wants to merge 1 commit into from

Conversation

glenn20
Copy link
Contributor

@glenn20 glenn20 commented Jun 2, 2023

Ensure "mpremote fs cp -r dir :" creates empty sub-dirs on the remote.

Currently, empty sub-directories are skipped during a recursive copy from the local filesystem.

This PR ensure that empty sub-directories are re-created on the remote device.

@glenn20
mpremote: Copy empty sub-dirs with "cp -r dir :".
37aed12 
Ensure "cp -r dir :" creates empty sub-dirs on the remote.

Signed-off-by: Glenn Moloney <glenn.moloney@gmail.com>
@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +0 +0.000% PYBV10
        rp2:    +0 +0.000% PICO

@jimmo
Copy link
Member

jimmo commented Jun 15, 2023

I have included a fix for the same issue in #11777

@glenn20
Copy link
Contributor Author

glenn20 commented Jun 15, 2023

Closing for #11777 .

@glenn20 glenn20 closed this Jun 15, 2023
@glenn20 glenn20 deleted the mpremote-cp-r-empty-dirs branch June 15, 2023 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glenn20 @jimmo