Skip to content

Cs205 #1202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Cs205 #1202

wants to merge 6 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 27, 2015

No description provided.

@ghost ghost closed this Apr 27, 2015
@ghost ghost reopened this Apr 27, 2015
@dpgeorge
Copy link
Member

Thanks for your contribution.... but there are many reasons why this PR can't be merged (no description, code style, left over backup files). The main one is that these functions don't belong in the math module. The math module should only have functions that standard Python has in it (unless there's a good reason to add something non standard).

If you want to fix it then, first, please find a proper module to put these functions in. Eg numpy.dot, numpy.fft.fft.

(I assume cs205 is a compute science course...)

@ghost
Copy link
Author

ghost commented Apr 27, 2015

Oh my, my apologies. I thought I had just duplicated the micropython repo, and had no idea my pull request was going anywhere other than my own copy. I was just hacking around to get a feel for the project. Perhaps once I get a little bit more familiar I will try to commit some numpy modules.
Thanks, and sorry again!

@dpgeorge
Copy link
Member

@jamesjlong ok, no problem!

@dpgeorge dpgeorge closed this Apr 27, 2015
tannewt pushed a commit to tannewt/circuitpython that referenced this pull request Sep 21, 2018
…ency

Clock the SAMD21 much faster so it can actually convert at its max
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants