Skip to content

extmod/modselect: Properly track number of poll objects that are fd's. #12224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 14, 2023
Merged

extmod/modselect: Properly track number of poll objects that are fd's. #12224

merged 2 commits into from
Aug 14, 2023

Conversation

dpgeorge
Copy link
Member

No description provided.

@dpgeorge dpgeorge added the extmod Relates to extmod/ directory in source label Aug 14, 2023
@dpgeorge dpgeorge mentioned this pull request Aug 14, 2023
Merged
1 task
@github-actions
Copy link

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:   +48 +0.006% standard
      stm32:    +0 +0.000% PYBV10
     mimxrt:    +0 +0.000% TEENSY40
        rp2:    +0 +0.000% PICO
       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS

@codecov
Copy link

codecov bot commented Aug 14, 2023 •
edited
Loading

Codecov Report

Merging #12224 (4fd1294) into master (24a6e95) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 4fd1294 differs from pull request most recent head 8851800. Consider uploading reports for the commit 8851800 to get more accurate results

@@           Coverage Diff           @@
##           master   #12224   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files         158      158           
  Lines       20895    20898    +3     
=======================================
+ Hits        20558    20561    +3     
  Misses        337      337
Files Changed Coverage Δ
extmod/modselect.c 98.89% <100.00%> (+0.01%) ⬆️

@dpgeorge dpgeorge force-pushed the extmod-select-fix-deleted-fd branch from 4c7ef10 to e2630e1 Compare August 14, 2023 04:41
@dpgeorge dpgeorge added this to the release-1.21.0 milestone Aug 14, 2023
@dpgeorge
extmod/modselect: Properly track number of poll objects that are fd's.
f6af484 
Signed-off-by: Damien George <damien@micropython.org>
@dpgeorge dpgeorge force-pushed the extmod-select-fix-deleted-fd branch from e2630e1 to f6af484 Compare August 14, 2023 08:50
@dpgeorge
tests/extmod/select_poll_eintr.py: Improve robustness of test.
8851800 
Increase allowed range of dt_ms, and print it in case of failure.

Signed-off-by: Damien George <damien@micropython.org>
@dpgeorge dpgeorge force-pushed the extmod-select-fix-deleted-fd branch from 4fd1294 to 8851800 Compare August 14, 2023 14:09
@dpgeorge dpgeorge merged commit 8851800 into micropython:master Aug 14, 2023
@dpgeorge dpgeorge deleted the extmod-select-fix-deleted-fd branch August 14, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
extmod Relates to extmod/ directory in source
Projects
None yet
Milestone
release-1.21.0
Development

Successfully merging this pull request may close these issues.
1 participant
@dpgeorge