Skip to content

samd: Add board definition for Sparkfun SAMD51 MicroMod #12642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andrewteta
Copy link

No description provided.

@andrewleech
Copy link
Contributor

andrewleech commented Oct 9, 2023

Looking much closer now! The commit message checker here is really strict, I think it'l' still just need a . on the end.
That can be added with a git commit --amend to update the message, then git push --force.

Oh yeah the commit message will also need the signed-off bit which you could add at the same time. https://github.com/jimmo/git-and-micropython#i-forgot-to-sign-off-a-commit

Signed-off-by: Andrew Teta <andrew.teta@gmail.com>
@robert-hh robert-hh added the board-definition New or updated board definition files. Combine with a port- label. label Oct 10, 2023
@robert-hh
Copy link
Contributor

Since PR #12211, the pins.csv file has been changed.

  • the columns of the file are swapped. It's board_name, pin_name now.
  • the pin names have changed form PIN_Pxnn to Pxnn, e.g. PIN_PA00 to PA00.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
board-definition New or updated board definition files. Combine with a port- label.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants