I think you may have some really outdated changes, I didn't look at the whole PR but note that mimxrt already has working WiFi and BLE support using nimble and cyw43, I added it myself some time ago, so some of your changes duplicate things (for example see mp_bluetooth_deinit() in main.c, and port files in Makefile etc..), also nimble.mk includes the paths you added. Like I said it's already working, you just need to add support for new NICs/drivers (Nina/esp_hosted).

Thanks for the hint and maybe it's the case. The history of this PR starts earlier than the inclusion of the cyw43 support. Since you looked at it already, can you be specific about the places were things are duplicated?

Edit: I see the duplicate of deinit. And I used already earlier the mpbthciport.c file introduced with the cyw43 support.
Edit2: I know the there is support for cyw43. Only the existing boards cannot use it. The added support for NINA or esp_hosted based devices allow users to add WiFi/BLE to other boards as well.

Since you looked at it already, can you be specific about the places were things are duplicated?

I left a quick review, anything removed I think is duplicated.

Edit2: I know the there is support for cyw43. Only the existing boards cannot use it. The added support for NINA or esp_hosted based devices allow users to add WiFi/BLE to other boards as well.

I understand, but what I meant is: there's already working support for nimble and LWIP, in that port, which means you only need to add support for Nina/Esp hosted.

Thanks for the review. I was a little bit overwhelmed by the fact that git managed to merge 3 branches with almost no conflict. But I did not check for duplicated. Still CI reports a build error: [proto_c cannot be found](make: protoc-c: Command not found). Sometimes it works.

Thanks for the review. I was a little bit overwhelmed by the fact that git managed to merge 3 branches

Yes it looked like a bad git merge. Anyway, I can take another look tomorrow.

Still CI reports a build error: [proto_c cannot be found](make: protoc-c: Command not found). Sometimes it works.

You must make submodules with the BOARD set, see ci_renesas_ra_board_build in tools/ci.sh

About Proto-c: It works locally. And when I do the make BOARD=xxx submodules and try to push it, there is no change to push.
Edit: I think I got it. Have to change ci.sh.

Code size report:

function ci_mimxrt_build {
    make ${MAKEOPTS} -C mpy-cross
    make ${MAKEOPTS} -C ports/mimxrt BOARD=MIMXRT1020_EVK submodules
    make ${MAKEOPTS} -C ports/mimxrt BOARD=MIMXRT1020_EVK
    make ${MAKEOPTS} -C ports/mimxrt BOARD=TEENSY40 submodules
    make ${MAKEOPTS} -C ports/mimxrt BOARD=TEENSY40
}

I'm not sure why boards are built twice, but I think you need to add submodules to every build.

Oh okay first line checks out the submodules, in that case I'm not sure why it's failing.

Proto-c was not installed. See a few lines up. The error about proto-c is now gone, only I have to clean up the manifest.py files. But maybe not today anymore.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.54%. Comparing base (0b72962) to head (5f10e49).

@@           Coverage Diff           @@
##           master   #12937   +/-   ##
=======================================
  Coverage   98.54%   98.54%           
=======================================
  Files         169      169           
  Lines       21889    21889           
=======================================
  Hits        21570    21570           
  Misses        319      319           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Closing in favor of supporting instead PPP. Then the user can go for a communication suitable method.

Hi @robert-hh other than the chain of dependencies of this PR is there anything particularly wrong with it?
Are there conflicts with the PPP work?

For context in planning on using this PR at work to add wireless networking to mimxrt platforms, PPP doesn't really help here at all.

I don't have suitable hardware set up though so haven't scheduled testing this yet.

Hi @robert-hh other than the chain of dependencies of this PR is there anything particularly wrong with it?

No. It works fine. And there should be not conflict with PPP, other than lacking PPP would not work on MIMXRT101x boards. If you think it's useful, I can reopen it. Only keeping such a large PR alive and working is quite laborious.

Thanks @robert-hh for this piece of work. It is worth merging, I just didn't get a chance to review it. I'll try to do that soon.

@dpgeorge Thank you for your response. I had a PR for similar support at the SAMD port. I closed it, expecting that with the VFSROM support the flash space would not be sufficient any more. The WiFI only version leaves ~90k free, the WiFi+BLE variant about 5k.

Let's get this one through first, then we can consider the samd version.