ports/esp32: Disable unused mbedtls options. #13067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpgeorge
reviewed
Nov 28, 2023
| CONFIG_MBEDTLS_ECP_DP_BP256R1_ENABLED=n | ||
| CONFIG_MBEDTLS_ECP_DP_BP384R1_ENABLED=n | ||
| CONFIG_MBEDTLS_ECP_DP_BP512R1_ENABLED=n | ||
| CONFIG_MBEDTLS_ECP_DP_CURVE25519_ENABLED=n |
There was a problem hiding this comment.
In what way are these unused? Do you mean that the other ports don't enable them by default? Or that they can never be utilised during a connection?
There was a problem hiding this comment.
Those options were disabled in the other ports in #9506, so now this is for esp32 port.
FYI I've just realised after checking sdkconfig in the build-ESP32_GENERIC dir e.g.
$ cat sdkconfig | grep MBEDTLS
...
CONFIG_MBEDTLS_ECP_DP_SECP192R1_ENABLED=y
CONFIG_MBEDTLS_ECP_DP_SECP224R1_ENABLED=y
CONFIG_MBEDTLS_ECP_DP_SECP256R1_ENABLED=y
CONFIG_MBEDTLS_ECP_DP_SECP384R1_ENABLED=y
CONFIG_MBEDTLS_ECP_DP_SECP521R1_ENABLED=y
CONFIG_MBEDTLS_ECP_DP_SECP192K1_ENABLED=y
CONFIG_MBEDTLS_ECP_DP_SECP224K1_ENABLED=y
CONFIG_MBEDTLS_ECP_DP_SECP256K1_ENABLED=y
CONFIG_MBEDTLS_ECP_DP_BP256R1_ENABLED=y
CONFIG_MBEDTLS_ECP_DP_BP384R1_ENABLED=y
CONFIG_MBEDTLS_ECP_DP_BP512R1_ENABLED=y
CONFIG_MBEDTLS_ECP_DP_CURVE25519_ENABLED=y
...
And for the bundle certificate
CONFIG_MBEDTLS_CERTIFICATE_BUNDLE=y
CONFIG_MBEDTLS_CERTIFICATE_BUNDLE_DEFAULT_FULL=y
Which I think is this file x509_crt_bundle.S and the firmware size diff with this PR is -15568 bytes.
There was a problem hiding this comment.
Ah, I see, they were removed from other ports in 68f166d
Disable unused EC curves and default certificate bundle which is not implemented in MicroPython. This reduces the firmware size significantly. This follows commit 68f166d. Signed-off-by: Carlos Gil Gonzalez <carlosgilglez@gmail.com>
|
Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable unused EC curves and default certificate bundle which is not implemented in MicroPython.
So this should reduce the firmware size significatively.