esp32/modesp32.c: Add mcu_temperature() function for C3/S2/S3 devices. #13276
Conversation
|
Looks good to me. Tested it on custom S3 and C3 boards and seems to work well in my brief test. |
|
Thanks for checking |
docs/esp32/quickref.rst
Outdated
| @@ -18,6 +18,9 @@ working with this board it may be useful to get an overview of the microcontroll | |||
| general.rst | |||
| tutorial/index.rst | |||
|
|
|||
| Note that there are several varieties of ESP32- ESP32, ESP32C3, ESP32S2, ESP32S3 supported by MicroPython, | |||
There was a problem hiding this comment.
This is a nitpick but please use the same chip naming schema as Espressif (and elsewhere in the docs), i.e. ESP32-C3, ESP32-S2, etc.
There was a problem hiding this comment.
Will update soon. Just need to get my courage up for trying to update pull request correctly...
There was a problem hiding this comment.
I don't know if this is useful, but jim has some tips here: https://github.com/jimmo/git-and-micropython?tab=readme-ov-file#i-want-to-make-changes-to-the-commits-my-pr--branch
If all else fails, making a new commit and pushing it to this branch is fine - we can squash the commits down before merging.
|
This is an automated heads-up that we've just merged a Pull Request See #13763 A search suggests this PR might apply the STATIC macro to some C code. If it Although this is an automated message, feel free to @-reply to me directly if |
dcc21ec to
3832098
Compare
|
esp32.raw_temperature() seems to be missing on esp32 S3 Firmware with Support for Octal-SPIRAM >>> import esp32
>>> esp32.raw_temperature()
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
AttributeError: 'module' object has no attribute 'raw_temperature'
>>> help(esp32)
object <module 'esp32'> is of type module
__name__ -- esp32
wake_on_touch -- <function>
wake_on_ext0 -- <function>
wake_on_ext1 -- <function>
wake_on_ulp -- <function>
gpio_deep_sleep_hold -- <function>
idf_heap_info -- <function>
NVS -- <class 'NVS'>
Partition -- <class 'Partition'>
RMT -- <class 'RMT'>
ULP -- <class 'ULP'>
WAKEUP_ALL_LOW -- False
WAKEUP_ANY_HIGH -- True
HEAP_DATA -- 4
HEAP_EXEC -- 1 |
|
@Rumidom I believe all the newer architectures (C2, S2, S3 .. C6?) use the newer IDF 5.x libraries. This PR is an attempt to include them but has not been integrated yet. Part of that is because I have not completely figured out how to fix all the errors, and part is fitting in with the micropython development process. |
|
The error may be caused by your habit or merging the master branch into your PR branch, instead for rebasing you branch onto the master. I do not know how to fix that. Maybe it's easier to create a new branch from the actual master and then cherry-pick the commit that make up you PR from the previous branch. Like, when you checked out the new branch: git checkout master And then re-edit esp32/modesp.c to change STATIC into static. The above mentioned has is 798fb80, but I do not know if it's the same on your PC. |
Signed-off-by: Rick Sorensen <rick.sorensen@gmail.com>
For ESP32C3/S2/S3 IDFv5 exposes new internal temperature API which is different to the base ESP32, IDFv4. Thanks to @robert-hh for cleaner code and testing sensor capability in these devices. See discussion micropython#10443. Signed-off-by: Rick Sorensen <rick.sorensen@gmail.com>
For ESP32C3/S2/S3 IDFv5 exposes new internal temperature API which is different than base ESP32, IDFv4.
Thanks to @robert-hh for cleaner code and testing sensor capability in these devices.
See discussion #10443