Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +0 +0.000% PYBV10
     mimxrt:    +0 +0.000% TEENSY40
        rp2:    +0 +0.000% RPI_PICO
       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bd21820) 98.36% compared to head (4bbb70e) 98.36%.
Report is 5 commits behind head on master.

@@           Coverage Diff           @@
##           master   #13400   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files         159      159           
  Lines       21088    21088           
=======================================
  Hits        20743    20743           
  Misses        345      345           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IhorNehrutsa Could you please explain the reasoning behind this feature?

My understanding is that the API in esp_hosted_hal.h is for integrating an arbitrary program with the ESP Hosted logging functions, so it's designed around ESP Hosted (and ESP-IDF ) logging conventions. Moving that ESP Hosted feature (and design) to become a core part of MicroPython is a big change.

Suggest a good place to start is these two questions from last time:

• What problem does this solve?
• Can you please walk step by step through a hypothetical example that explains how a developer would use this to find and debug some MicroPython behaviour? EDIT: an example that isn't possible with the current approach of uncommenting debug_printf in some files(s).

Plus two new questions:

• Why choose this API for MicroPython logging?
• What's the plan for documenting this API and ensuring it's adopted, if it's going to be a core part of MP?

My understanding is that the API in esp_hosted_hal.h is for integrating an arbitrary program with the ESP Hosted logging functions, so it's designed around ESP Hosted (and ESP-IDF ) logging conventions

Those macros were actually just meant to be used internally by the esp-hosted driver as a debugging aid, they are also unrelated to ESP-IDF. It was just becoming hard to see useful error output from debugging, warnings etc.. and I wanted some colorful output :) It would be nice if they are standardized in MicroPython, and replace all internal debugging macros/helpers at some point, but they could probably use some work first. Re the context, it can be maintained by using __FILE__ and __LINE__ etc..

Thanks for the contribution, but we don't need all this additional complexity in MicroPython. I know it's not adding any code size, but it adds lines to the source files and that adds to the complexity for someone reading and trying to understand the code.

The printf-style debugging that we do have in MicroPython is already plenty, and should be done using local-to-the-file DEBUG_printf() macros.