esp32: Allow to use the DEBUG_printf. #13525
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2a5d220 to
7078a06
Compare
|
py/mpprint.h: Add do_printf() macro. #13400 |
dpgeorge
reviewed
Jan 29, 2024
ports/esp32/mpconfigport.h
Outdated
| @@ -69,6 +69,7 @@ | |||
| #define MICROPY_STREAMS_POSIX_API (1) | |||
| #define MICROPY_USE_INTERNAL_ERRNO (0) // errno.h from xtensa-esp32-elf/sys-include/sys | |||
| #define MICROPY_USE_INTERNAL_PRINTF (0) // ESP32 SDK requires its own printf | |||
| #define MICROPY_DEBUG_PRINTERS (1) | |||
There was a problem hiding this comment.
I don't think it makes sense to enable this by default. When you build your own board you can easily enable it in the boards config file.
Signed-off-by: IhorNehrutsa <Ihor.Nehrutsa@gmail.com>
7078a06 to
9dfc88b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.