-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
esp32/modsmartconfig: Add smartconfig module. #13658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
You can go with |
In the present, because of 2.4G-5G mixed WiFi and WiFi6 routers, |
817af5c
to
47fd1a1
Compare
a698696
to
de7eb99
Compare
Rebase all commits to single one, and append document for smartconfig. |
a1d39be
to
ceb2b1e
Compare
Hi @projectgus, I didn't keep working on #4404 , because the ESP32 port requires ESP-IDF v5, which is a lot different than before, so I chose to start over. |
According to PR #13763 removed all |
It looks like a nice feature, though I hadn't come across it before. I presume you've tested it? :) I would guess that the maintainers would prefer this to be an optional component (even if it default to on by default). To save folks from looking at the docs you've created (which are good, nice job!), they can read about this feature by looking at the Espressif SmartConfig documentation. |
@mattytrentini thanks for your review.
About the optional component, here is my thoughts:
I have tried these steps,
I see what you mean, aligning the function names in the component to the function names in the idf documentation. But I can't fully agree with you, even if you do align the function names, there're still some differences between them, for example, the IDF API doesn't directly return the information, such as |
This is a amazing PR, thank you guys! |
The following changes were made in this update:
|
Hope this will add to normal Micropython too! |
@PIBSAS thanks for your reply. |
19ac0f6
to
e835926
Compare
Code size report:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #13658 +/- ##
=======================================
Coverage 98.57% 98.57%
=======================================
Files 164 164
Lines 21336 21336
=======================================
Hits 21031 21031
Misses 305 305 ☔ View full report in Codecov by Sentry. |
I have no idea why there are 4 more files in the file changed list and the number of checks has increased to 67 and one of them fails.... |
e835926
to
6e7d613
Compare
Signed-off-by: Walkline Wang <walkline@gmail.com>
Signed-off-by: Walkine Wang <walkline@gmail.com>
* Added version(), timeout(), fast_mode() and v2_key() functions. * Renamed function rvd_data() to v2_data(). * Change the return value type of v2_data() to str. Signed-off-by: Walkine Wang <walkline@gmail.com>
Change data length from 32 to 64, to fit the maximum length specified by the EspTouch app. Signed-off-by: Walkline80 <walkline@gmail.com>
864f7d7
to
06a72b3
Compare
Signed-off-by: Walkline Wang <walkline@gmail.com>
06a72b3
to
0836e23
Compare
Here is the test code which shown all methods and constants belong to smartconfig module, I was compiled firmware with
micropython master
(synced yesterday) andesp-idf v5.0.4
, separately tested onesp32
andesp32c3
develop board.Update: Tested
v5.1.2
andv5.2.2
in addition toesp-idf v5.0.4
, compiled the firmware using the latest MicroPython code.