Note: It may be prudent to try the "apt install uncrustify" step first and only install from source if there's a version mismatch. This would avoid any performance impact both on CI and to developers who already have the correct version.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.42%. Comparing base (3c8089d) to head (d03889b).
Report is 812 commits behind head on master.

@@           Coverage Diff           @@
##           master   #15221   +/-   ##
=======================================
  Coverage   98.42%   98.42%           
=======================================
  Files         161      161           
  Lines       21204    21204           
=======================================
  Hits        20870    20870           
  Misses        334      334           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +0 +0.000% PYBV10
     mimxrt:    +0 +0.000% TEENSY40
        rp2:    +0 +0.000% RPI_PICO_W
       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS

@dlech just built a pypi package that installs the proper version:
https://pypi.org/project/micropython-uncrustify/

See https://github.com/orgs/micropython/discussions/14496

FYI, I recently published https://pypi.org/project/micropython-uncrustify/ to have an easy way to get a pre-compiled binary with the correct version of uncrustify. This would be more efficient than everyone having to compile it themselves.

Haha, now that's an approach. D'oh!

Downside is that you probably now have to contend with cursed virtualenvs somehow 🫠 ... but that's not my problem runs away

Happy to close this and defer to whatever solution you're cookin' up! I got a little carried away 😆

Hmmm, well it works -

brew install virtualenvwrapper pyenv-virtualenvwrapper
source virtualenvwrapper.sh
mkvirtualenv micropython
pip install micropython-uncrustify
~/.virtualenvs/micropython/bin/uncrustify --version 
Uncrustify-f44f717

And bonus points for Windows builds!

I guess it's supposed to huck it into /bin if I do naughty things with system python?

You can also run it like this if you don't want to make a vritualenv or pollute your PATH.

pipx run --spec micropython-uncrustify uncrustify --version

pipx aha, that's the one people keep telling me about that my brain never retains. TIL, thank you.

Though, uh, remind me not to try and brew install pipx again... kicked off some kind of dependency chain chaos involving ffmpeg.

Oh nice work, @dlech! I mentioned in the linked issue that I did some work getting uncrustify to build under wasm, but it's even better if you've got it building native binaries for all of the relevant architectures.

Downside is that you probably now have to contend with cursed virtualenvs somehow 🫠 ... but that's not my problem runs away

pre-commit manages its own sandbox Python environments, from what I can tell, and it seems pretty seamless. So I think what we can probably do is make a pre-commit hook that installs and runs the correct micropython-uncrustify version and that should be pretty seamless for most #users. EDIT: I must have remembered this wrong, it is just using the current virtualenv I think.