Skip to content

webassembly/objjsproxy: Implement proxying of JS iterable protocol. #15293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

dpgeorge
Copy link
Member

This allows Python to iterate over JavaScript objects that provide Symbol.iterator.

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.42%. Comparing base (2b0e64b) to head (a053e63).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #15293   +/-   ##
=======================================
  Coverage   98.42%   98.42%           
=======================================
  Files         161      161           
  Lines       21204    21204           
=======================================
  Hits        20870    20870           
  Misses        334      334           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WebReflection
Copy link
Contributor

virtual 👍 to me ... if you merge and you don't mind, please publish to npm so we can scratch one more issue from our side, thank you!

This allows Python to iterate over JavaScript objects that provide
Symbol.iterator.

Signed-off-by: Damien George <damien@micropython.org>
@dpgeorge dpgeorge force-pushed the webassembly-js-proxy-iter branch from 74d7347 to a053e63 Compare June 18, 2024 12:15
@dpgeorge dpgeorge merged commit a053e63 into micropython:master Jun 18, 2024
@dpgeorge dpgeorge deleted the webassembly-js-proxy-iter branch June 18, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants