py/objdeque.c: correct type flags based on option settings #15316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Halbert <halbert@halwitz.org>
72fb0ad to
ea30af3
Compare
|
Code size report: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15316 +/- ##
=======================================
Coverage 98.42% 98.42%
=======================================
Files 161 161
Lines 21204 21204
=======================================
Hits 20870 20870
Misses 334 334 ☔ View full report in Codecov by Sentry. |
|
I'm puzzled by the CI failure here: https://github.com/micropython/micropython/actions/runs/9597460366/job/26466587697?pr=15316#step:4:996. Maybe it's something intermittent. |
|
Thanks for the fix, rebased and merged in 5040b13 (yes the CI is a bit flaky sometimes...) |
|
See follow up in #15324. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a minor issue in the changes made by #10724. The type flags for
dequewere meant to be conditionalized based onMICROPY_PY_COLLECTIONS_DEQUE_ITER, but the computed conditionalized value wasn't used.Discovered by accident while addressing adafruit#9355. @SAK917 recently added #10724 to CircuitPython via adafruit#9065.
@LordFlashmeow can you confirm this is what you wanted?