Skip to content

Remove old board variants #15639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Remove old board variants #15639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad38299
samd/boards/ADAFRUIT_METRO_M4_EXPRESS: Remove wlan variant.
mattytrentini Aug 14, 2024
b704ff6
esp32/boards: Remove all IDF3 variants.
mattytrentini Aug 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ports/esp32/boards/ESP32_GENERIC/board.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
"thumbnail": "",
"url": "https://www.espressif.com/en/products/modules",
"variants": {
"IDF3": "Compiled with IDF 3.x",
"D2WD": "ESP32 D2WD",
"SPIRAM": "Support for SPIRAM / WROVER",
"UNICORE": "ESP32 Unicore",
Expand Down
3 changes: 0 additions & 3 deletions ports/esp32/boards/UM_TINYPICO/board.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,5 @@
"product": "TinyPICO",
"thumbnail": "",
"url": "https://www.tinypico.com/",
"variants": {
"IDF3": "Compiled with IDF 3.x"
},
"vendor": "Unexpected Maker"
}
3 changes: 0 additions & 3 deletions ports/samd/boards/ADAFRUIT_METRO_M4_EXPRESS/board.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@
"metro_m4_express_airlift.jpg"
],
"mcu": "samd51",
"variants": {
"wlan": "WLAN without SSL support"
},
"product": "Metro M4 Express Airlift",
"thumbnail": "",
"url": "https://www.adafruit.com/product/4000",
Expand Down
6 changes: 2 additions & 4 deletions tools/autobuild/build-boards.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,8 @@ function build_board {
$MICROPY_AUTOBUILD_MAKE BOARD=$board BUILD=$build_dir && copy_artefacts $dest_dir $descr $fw_tag $build_dir $@
rm -rf $build_dir

# Query variants from board.json and build them. Ignore the special "IDF3"
# variant for ESP32 boards (this allows the downloads page to still have
# the idf3 files for older releases that used to be explicitly built).
for variant in `cat $board_json | python3 -c "import json,sys; print(' '.join(v for v in json.load(sys.stdin).get('variants', {}).keys() if v != 'IDF3'))"`; do
# Query variants from board.json and build them.
for variant in `cat $board_json | python3 -c "import json,sys; print(' '.join(json.load(sys.stdin).get('variants', {}).keys()))"`; do
local variant_build_dir=$build_dir-$variant
echo "building variant $descr $board $variant"
$MICROPY_AUTOBUILD_MAKE BOARD=$board BOARD_VARIANT=$variant BUILD=$variant_build_dir && copy_artefacts $dest_dir $descr-$variant $fw_tag $variant_build_dir $@
Expand Down
Loading