Skip to content

qemu: Rename qemu-arm port to qemu. #15784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

dpgeorge
Copy link
Member

@dpgeorge dpgeorge commented Sep 4, 2024

Because this port now supports multiple architectures.

Follow-up to #15743.

@dpgeorge dpgeorge added the ports Relates to multiple ports, or a new/proposed port label Sep 4, 2024
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.43%. Comparing base (0426934) to head (6591138).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #15784   +/-   ##
=======================================
  Coverage   98.43%   98.43%           
=======================================
  Files         163      163           
  Lines       21294    21294           
=======================================
  Hits        20960    20960           
  Misses        334      334           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Sep 4, 2024

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +0 +0.000% PYBV10
     mimxrt:    +0 +0.000% TEENSY40
        rp2:    +0 +0.000% RPI_PICO_W
       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS

@dpgeorge
Copy link
Member Author

dpgeorge commented Sep 5, 2024

@agatti does this rename look good to you?

@agatti
Copy link
Contributor

agatti commented Sep 5, 2024

At a first glance it looks OK, although for #15714 I will have to rename ports/qemu/test-frzmpy/frozen_asm.py to make it unique to the Arm port and add a similar file for RV32 (and modify the makefiles to reflect that of course).

@dpgeorge
Copy link
Member Author

dpgeorge commented Sep 5, 2024

I will have to rename ports/qemu/test-frzmpy/frozen_asm.py to make it unique to the Arm port

That sounds fine, you can do that as part of #15714.

@agatti
Copy link
Contributor

agatti commented Sep 5, 2024

I'll wait for this to land then. Thank you.

Signed-off-by: Damien George <damien@micropython.org>
Because this port now supports multiple architectures.

Signed-off-by: Damien George <damien@micropython.org>
@dpgeorge dpgeorge force-pushed the qemu-arm-rename-to-qemu branch from d2bfc73 to 6591138 Compare September 6, 2024 01:09
@dpgeorge dpgeorge merged commit 6591138 into micropython:master Sep 6, 2024
66 checks passed
@dpgeorge dpgeorge deleted the qemu-arm-rename-to-qemu branch September 6, 2024 06:56
@dpgeorge
Copy link
Member Author

dpgeorge commented Sep 6, 2024

@agatti this is now merged.

@agatti
Copy link
Contributor

agatti commented Sep 6, 2024

Thanks, I've updated #15714 accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ports Relates to multiple ports, or a new/proposed port
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants